From: Michał Kępień <michal@isc.org>
Date: Thu, 7 Nov 2019 11:25:39 +0000 (+0100)
Subject: Fix argument order in assert_int_equal()
X-Git-Tag: v9.15.6~22^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bd1f68bef1fdadcd385322e11f3e9cd1b89f94c;p=thirdparty%2Fbind9.git

Fix argument order in assert_int_equal()

assert_int_equal() calls in bin/tests/system/tcp/tests.sh pass the found
value as the first argument and the expected value as the second
argument, while the function interprets its arguments the other way
round.  Fix argument handling in assert_int_equal() to make sure the
error messages printed by that function are correct.
---

diff --git a/bin/tests/system/conf.sh.common b/bin/tests/system/conf.sh.common
index c9564ac6306..51c0f399f55 100644
--- a/bin/tests/system/conf.sh.common
+++ b/bin/tests/system/conf.sh.common
@@ -208,12 +208,12 @@ DISABLED_BITS=384
 # the error using the description of the tested variable provided in $3
 # and return 1.
 assert_int_equal() {
-	expected="$1"
-	found="$2"
+	found="$1"
+	expected="$2"
 	description="$3"
 
 	if [ "${expected}" -ne "${found}" ]; then
-		echo_i "incorrect ${description}: expected ${expected}, got ${found}"
+		echo_i "incorrect ${description}: got ${found}, expected ${expected}"
 		return 1
 	fi