From: Mike Yuan <me@yhndnzj.com>
Date: Sat, 15 Feb 2025 22:43:11 +0000 (+0100)
Subject: basic/escape: swap 'bad' and 'len' params for decescape()
X-Git-Tag: v258-rc1~1329^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bdbfb7eb6f929bf02602b11f103b1d767828272;p=thirdparty%2Fsystemd.git

basic/escape: swap 'bad' and 'len' params for decescape()

To follow our usual coding style.
---

diff --git a/src/basic/escape.c b/src/basic/escape.c
index 81d15a67cdb..e1ded559811 100644
--- a/src/basic/escape.c
+++ b/src/basic/escape.c
@@ -478,7 +478,7 @@ char* octescape(const char *s, size_t len) {
         return buf;
 }
 
-char* decescape(const char *s, const char *bad, size_t len) {
+char* decescape(const char *s, size_t len, const char *bad) {
         char *buf, *t;
 
         /* Escapes all chars in bad, in addition to \ and " chars, in \nnn decimal style escaping. */
diff --git a/src/basic/escape.h b/src/basic/escape.h
index e922b6693b3..46ccaf78ec1 100644
--- a/src/basic/escape.h
+++ b/src/basic/escape.h
@@ -67,7 +67,7 @@ static inline char* xescape(const char *s, const char *bad) {
         return xescape_full(s, bad, SIZE_MAX, 0);
 }
 char* octescape(const char *s, size_t len);
-char* decescape(const char *s, const char *bad, size_t len);
+char* decescape(const char *s, size_t len, const char *bad);
 char* escape_non_printable_full(const char *str, size_t console_width, XEscapeFlags flags);
 
 char* shell_escape(const char *s, const char *bad);
diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-rr.c
index bbd0aef1c80..7f0898af6b2 100644
--- a/src/resolve/resolved-dns-rr.c
+++ b/src/resolve/resolved-dns-rr.c
@@ -931,7 +931,7 @@ static char *format_svc_param_value(DnsSvcParam *i) {
                 return strv_join(values_strv, ",");
         }
         default: {
-                value = decescape((char *)&i->value, " ,", i->length);
+                value = decescape((char*) &i->value, i->length, " ,");
                 if (!value)
                         return NULL;
                 break;
diff --git a/src/test/test-escape.c b/src/test/test-escape.c
index 7021ff54d2b..e4dfe32c04d 100644
--- a/src/test/test-escape.c
+++ b/src/test/test-escape.c
@@ -242,7 +242,7 @@ TEST(octescape) {
 static void test_decescape_one(const char *s, const char *bad, const char *expected) {
         _cleanup_free_ char *ret = NULL;
 
-        assert_se(ret = decescape(s, bad, strlen_ptr(s)));
+        assert_se(ret = decescape(s, s ? SIZE_MAX : 0, bad));
         log_debug("decescape(\"%s\") → \"%s\" (expected: \"%s\")", strnull(s), ret, expected);
         ASSERT_STREQ(ret, expected);
 }