From: Willy Tarreau <w@1wt.eu>
Date: Wed, 6 Jul 2022 09:52:24 +0000 (+0200)
Subject: MINOR: cli/threads: always bind CLI to thread group 1
X-Git-Tag: v2.7-dev2~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bdf9452c09030d4944e6d045b6f60f55c38e97a;p=thirdparty%2Fhaproxy.git

MINOR: cli/threads: always bind CLI to thread group 1

When using multiple groups, the stats socket starts to emit errors and
it's not natural to have to touch the global section just to specify
"thread 1/all". Let's pre-attach these sockets to thread group 1. This
will cause errors when trying to change the group but this really is not
a problem for now as thread groups are not enabled by default. This will
make sure configs remain portable and may possibly be relaxed later.
---

diff --git a/src/cli.c b/src/cli.c
index abec46bf9c..722d0c63d9 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -492,6 +492,7 @@ static int cli_parse_global(char **args, int section_type, struct proxy *curpx,
 		}
 		bind_conf->level &= ~ACCESS_LVL_MASK;
 		bind_conf->level |= ACCESS_LVL_OPER; /* default access level */
+		bind_conf->bind_tgroup = 1; // bind to a single group in any case
 
 		if (!str2listener(args[2], global.cli_fe, bind_conf, file, line, err)) {
 			memprintf(err, "parsing [%s:%d] : '%s %s' : %s\n",