From: Ondřej Surý <ondrej@sury.org>
Date: Sun, 13 Oct 2019 04:47:26 +0000 (+0200)
Subject: named: Add INSIST() after bindkeysfile configuration load to silence scan-build FP
X-Git-Tag: v9.15.6~36^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6bf364aec87773764c2850a95251aa6a15cf320e;p=thirdparty%2Fbind9.git

named: Add INSIST() after bindkeysfile configuration load to silence scan-build FP
---

diff --git a/bin/named/server.c b/bin/named/server.c
index 2cd6b10d88f..014f7b9575b 100644
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -8098,6 +8098,7 @@ load_configuration(const char *filename, named_server_t *server,
 	INSIST(result == ISC_R_SUCCESS);
 	CHECKM(setstring(server, &server->bindkeysfile,
 	       cfg_obj_asstring(obj)), "strdup");
+	INSIST(server->bindkeysfile != NULL);
 
 	if (access(server->bindkeysfile, R_OK) == 0) {
 		isc_log_write(named_g_lctx, NAMED_LOGCATEGORY_GENERAL,