From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 20 Jul 2020 19:35:56 +0000 (+0900)
Subject: util: make siphash24_compress_boolean() inline
X-Git-Tag: v246-rc2~10^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c04fccb1db16e1a3140c01a536bff4ed342f8ed;p=thirdparty%2Fsystemd.git

util: make siphash24_compress_boolean() inline

This also changes the stored type from int to uint8_t in order to make
hash value endianness independent.
---

diff --git a/src/basic/siphash24.c b/src/basic/siphash24.c
index 666431aa31f..61180819b1b 100644
--- a/src/basic/siphash24.c
+++ b/src/basic/siphash24.c
@@ -151,12 +151,6 @@ void siphash24_compress(const void *_in, size_t inlen, struct siphash *state) {
         }
 }
 
-void siphash24_compress_boolean(bool in, struct siphash *state) {
-        int i = in;
-
-        siphash24_compress(&i, sizeof i, state);
-}
-
 uint64_t siphash24_finalize(struct siphash *state) {
         uint64_t b;
 
diff --git a/src/basic/siphash24.h b/src/basic/siphash24.h
index 1937fea2985..d29058e51dd 100644
--- a/src/basic/siphash24.h
+++ b/src/basic/siphash24.h
@@ -17,9 +17,14 @@ struct siphash {
 
 void siphash24_init(struct siphash *state, const uint8_t k[static 16]);
 void siphash24_compress(const void *in, size_t inlen, struct siphash *state);
-void siphash24_compress_boolean(bool in, struct siphash *state);
 #define siphash24_compress_byte(byte, state) siphash24_compress((const uint8_t[]) { (byte) }, 1, (state))
 
+static inline void siphash24_compress_boolean(bool in, struct siphash *state) {
+        uint8_t i = in;
+
+        siphash24_compress(&i, sizeof i, state);
+}
+
 uint64_t siphash24_finalize(struct siphash *state);
 
 uint64_t siphash24(const void *in, size_t inlen, const uint8_t k[static 16]);