From: Justin Viiret <justin.viiret@intel.com>
Date: Fri, 6 May 2016 04:20:38 +0000 (+1000)
Subject: ue2string: fix broken function type in upperString
X-Git-Tag: v4.2.0^2~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c1143a264e89eef01818dd80db0b4ca86f7ab32;p=thirdparty%2Fvectorscan.git

ue2string: fix broken function type in upperString

Silences warning from ubsan.
---

diff --git a/src/util/ue2string.cpp b/src/util/ue2string.cpp
index 6fdc57ba..7c16aa58 100644
--- a/src/util/ue2string.cpp
+++ b/src/util/ue2string.cpp
@@ -129,7 +129,9 @@ string dumpString(const ue2_literal &lit) {
 #endif
 
 void upperString(string &s) {
-    transform(s.begin(), s.end(), s.begin(), (int(*)(int)) mytoupper);
+    for (auto &c : s) {
+        c = mytoupper(c);
+    }
 }
 
 size_t maxStringOverlap(const string &a, const string &b, bool nocase) {