From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Sun, 5 Nov 2017 15:47:15 +0000 (+0200)
Subject: doveadm: Remove dead code
X-Git-Tag: 2.3.0.rc1~554
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c30d94bfa753a01e765a5e9713cbd33901dfb32;p=thirdparty%2Fdovecot%2Fcore.git

doveadm: Remove dead code

ret can never be >0 at this point. If there are any unexpected JSON
elements, doveadm_http_server_json_parse_v1() returns -1.
---

diff --git a/src/doveadm/client-connection-http.c b/src/doveadm/client-connection-http.c
index 3ad6c5ae7d..28ad80cca7 100644
--- a/src/doveadm/client-connection-http.c
+++ b/src/doveadm/client-connection-http.c
@@ -730,15 +730,6 @@ doveadm_http_server_read_request_v1(struct client_request_http *req)
 
 	doveadm_cmd_params_clean(&req->pargv);
 
-	if (ret > 0 && req->parse_state != CLIENT_REQUEST_PARSE_DONE) {
-		/* this may happen if the parser above runs into
-		   unexpected element, but JSON is OK */
-		http_server_request_fail_text(http_sreq,
-			400, "Bad Request",
-			"Unexpected JSON element in input");
-		return;
-	}
-
 	if (req->input->stream_errno != 0) {
 		http_server_request_fail_close(http_sreq,
 			400, "Client disconnected");