From: Mike Bayer Date: Tue, 14 Aug 2007 03:34:38 +0000 (+0000) Subject: - fixed endless loop X-Git-Tag: rel_0_4beta2~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c6cd47c024c5ea2cada04534aca818f95b8ea8c;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git - fixed endless loop - fixed perf imports in masseagerload --- diff --git a/lib/sqlalchemy/orm/session.py b/lib/sqlalchemy/orm/session.py index f8589dbe42..7e9b351e14 100644 --- a/lib/sqlalchemy/orm/session.py +++ b/lib/sqlalchemy/orm/session.py @@ -148,7 +148,8 @@ class SessionTransaction(object): self.nested = nested def connection(self, bindkey, **kwargs): - return self.session.connection(bindkey, **kwargs) + engine = self.session.get_bind(bindkey, **kwargs) + return self.get_or_add(engine) def _begin(self, **kwargs): return SessionTransaction(self.session, self, **kwargs) @@ -623,6 +624,8 @@ class Session(object): else: if isinstance(mapper, type): mapper = _class_mapper(mapper) + else: + mapper = mapper.compile() e = mapper.mapped_table.bind if e is None: raise exceptions.InvalidRequestError("Could not locate any Engine or Connection bound to mapper '%s'" % str(mapper)) diff --git a/test/perf/masseagerload.py b/test/perf/masseagerload.py index f1c0f292b0..ad438c1faa 100644 --- a/test/perf/masseagerload.py +++ b/test/perf/masseagerload.py @@ -1,5 +1,4 @@ import testbase -import hotshot, hotshot.stats from sqlalchemy import * from sqlalchemy.orm import * from testlib import * diff --git a/test/testlib/__init__.py b/test/testlib/__init__.py index bfc2ba04b2..046f8f9b40 100644 --- a/test/testlib/__init__.py +++ b/test/testlib/__init__.py @@ -7,10 +7,10 @@ import testlib.config from testlib.schema import Table, Column import testlib.testing as testing from testlib.testing import PersistTest, AssertMixin, ORMTest, SQLCompileTest -import testlib.profiling +import testlib.profiling as profiling import testlib.engines __all__ = ('testing', 'Table', 'Column', - 'PersistTest', 'AssertMixin', 'ORMTest', 'SQLCompileTest') + 'PersistTest', 'AssertMixin', 'ORMTest', 'SQLCompileTest', 'profiling')