From: Claudio Freire <klaussfreire@gmail.com>
Date: Wed, 2 Sep 2015 19:09:52 +0000 (-0300)
Subject: Move closed check inside the callback_lock
X-Git-Tag: v4.3.0b1~35^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c8453bf0a33091219951459b3dd9fc307ac2671;p=thirdparty%2Ftornado.git

Move closed check inside the callback_lock
---

diff --git a/tornado/ioloop.py b/tornado/ioloop.py
index 6068802e0..67935fcf5 100644
--- a/tornado/ioloop.py
+++ b/tornado/ioloop.py
@@ -912,12 +912,12 @@ class PollIOLoop(IOLoop):
         # The check doesn't need to be guarded by the callback lock,
         # since the GIL makes all access to it atomic, and it can
         # only ever transition to True
-        if self._closing:
-            raise RuntimeError("IOLoop is closing")
         if thread.get_ident() != self._thread_ident:
             # If we're not on the IOLoop's thread, we need to synchronize
             # with other threads, or waking logic will induce a race.
             with self._callback_lock:
+                if self._closing:
+                    raise RuntimeError("IOLoop is closing")
                 list_empty = not self._callbacks
                 self._callbacks.append(functools.partial(
                     stack_context.wrap(callback), *args, **kwargs))
@@ -929,6 +929,8 @@ class PollIOLoop(IOLoop):
                     # relatively expensive, so we try to avoid it when we can.
                     self._waker.wake()
         else:
+            if self._closing:
+                raise RuntimeError("IOLoop is closing")
             # If we're on the IOLoop's thread, we don't need the lock,
             # since we don't need to wake anyone, just add the callback.
             # Blindly insert into self._callbacks.