From: John Ferlan <jferlan@redhat.com>
Date: Fri, 24 Nov 2017 14:42:07 +0000 (-0500)
Subject: storage: Fix broken storage_driver build
X-Git-Tag: v3.10.0-rc1~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6caf67f83451aef002ba3167904d2e987906e25e;p=thirdparty%2Flibvirt.git

storage: Fix broken storage_driver build

Commit id '5d5c732d7' had an incorrect assignment and was found
by travis build:

storage/storage_driver.c:1668:14: error: equality comparison with extraneous
      parentheses [-Werror,-Wparentheses-equality]
    if ((obj == virStoragePoolObjListSearch(&driver->pools,

         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index cb45052ef7..561ca36f90 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1665,9 +1665,9 @@ storagePoolLookupByTargetPath(virConnectPtr conn,
         return NULL;
 
     storageDriverLock();
-    if ((obj == virStoragePoolObjListSearch(&driver->pools,
-                                            storagePoolLookupByTargetPathCallback,
-                                            path))) {
+    if ((obj = virStoragePoolObjListSearch(&driver->pools,
+                                           storagePoolLookupByTargetPathCallback,
+                                           path))) {
         def = virStoragePoolObjGetDef(obj);
         pool = virGetStoragePool(conn, def->name, def->uuid, NULL, NULL);
         virStoragePoolObjEndAPI(&obj);