From: Colin Ian King Date: Mon, 23 Jun 2025 22:20:04 +0000 (+0100) Subject: pinctrl: eswin: Fix unsigned comparison to less than zero issue X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6cb0e9da949aeb022b28a9b698f767c8828e283d;p=thirdparty%2Fkernel%2Flinux.git pinctrl: eswin: Fix unsigned comparison to less than zero issue The u32 variable voltage is being compared to less than zero and this can never be true. Fix this by making voltage an int type which is the same type as the return from the call to regulator_get_voltage. Fixes: 5b797bcc00ef ("pinctrl: eswin: Add EIC7700 pinctrl driver") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/20250623222004.280928-1-colin.i.king@gmail.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-eic7700.c b/drivers/pinctrl/pinctrl-eic7700.c index 719cd11e276aa..4874b55323439 100644 --- a/drivers/pinctrl/pinctrl-eic7700.c +++ b/drivers/pinctrl/pinctrl-eic7700.c @@ -622,8 +622,8 @@ static int eic7700_pinctrl_probe(struct platform_device *pdev) struct pinctrl_dev *pctldev; struct eic7700_pinctrl *pc; struct regulator *regulator; - u32 voltage, rgmii0_mode, rgmii1_mode; - int ret; + u32 rgmii0_mode, rgmii1_mode; + int ret, voltage; pc = devm_kzalloc(dev, struct_size(pc, functions, EIC7700_FUNCTIONS_COUNT), GFP_KERNEL); if (!pc)