From: Daniel Stenberg <daniel@haxx.se>
Date: Sun, 10 Jan 2021 23:13:01 +0000 (+0100)
Subject: connect: mark intentional ignores of setsockopt return values
X-Git-Tag: curl-7_75_0~124
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6cb803ecb10224d5a0edb090edaa9ebd16c15f33;p=thirdparty%2Fcurl.git

connect: mark intentional ignores of setsockopt return values

Pointed out by Coverity

Closes #6431
---

diff --git a/lib/connect.c b/lib/connect.c
index f7aa260199..345b800ee8 100644
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -5,7 +5,7 @@
  *                            | (__| |_| |  _ <| |___
  *                             \___|\___/|_| \_\_____|
  *
- * Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al.
+ * Copyright (C) 1998 - 2021, Daniel Stenberg, <daniel@haxx.se>, et al.
  *
  * This software is licensed as described in the file COPYING, which
  * you should have received as part of this distribution. The terms
@@ -445,7 +445,7 @@ static CURLcode bindlocal(struct connectdata *conn,
     }
   }
 #ifdef IP_BIND_ADDRESS_NO_PORT
-  setsockopt(sockfd, SOL_IP, IP_BIND_ADDRESS_NO_PORT, &on, sizeof(on));
+  (void)setsockopt(sockfd, SOL_IP, IP_BIND_ADDRESS_NO_PORT, &on, sizeof(on));
 #endif
   for(;;) {
     if(bind(sockfd, sock, sizeof_sa) >= 0) {
@@ -1578,18 +1578,17 @@ CURLcode Curl_socket(struct connectdata *conn,
   if(addr->socktype == SOCK_DGRAM) {
     int one = 1;
     switch(addr->family) {
-      case AF_INET:
-        setsockopt(*sockfd, SOL_IP, IP_RECVERR, &one, sizeof(one));
-        break;
-      case AF_INET6:
-        setsockopt(*sockfd, SOL_IPV6, IPV6_RECVERR, &one, sizeof(one));
-        break;
+    case AF_INET:
+      (void)setsockopt(*sockfd, SOL_IP, IP_RECVERR, &one, sizeof(one));
+      break;
+    case AF_INET6:
+      (void)setsockopt(*sockfd, SOL_IPV6, IPV6_RECVERR, &one, sizeof(one));
+      break;
     }
   }
 #endif
 
   return CURLE_OK;
-
 }
 
 /*