From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 18 Oct 2019 21:16:46 +0000 (+0200)
Subject: docs: hacking: remove reference to ATTRIBUTE_FORMAT
X-Git-Tag: v5.9.0-rc1~69
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6cc9b74e0e7b2f7dde443a4bca06f3435d70235e;p=thirdparty%2Flibvirt.git

docs: hacking: remove reference to ATTRIBUTE_FORMAT

Prefer G_GNUC_PRINTF.

Also, pick another example than virAsprintf since it may get
removed in the future.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 01c735120a..030d7818e3 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -1379,12 +1379,12 @@ BAD:
       Whenever you add a new printf-style function, i.e., one with a format
       string argument and following "..." in its prototype, be sure to use
       gcc's printf attribute directive in the prototype.  For example, here's
-      the one for virAsprintf, in util.h:
+      the one for virCommandAddEnvFormat in vircommand.h:
     </p>
 
 <pre>
-  int virAsprintf(char **strp, const char *fmt, ...)
-      ATTRIBUTE_FORMAT(printf, 2, 3);
+  void virCommandAddEnvFormat(virCommandPtr cmd, const char *format, ...)
+      G_GNUC_PRINTF(2, 3);
 </pre>
 
     <p>