From: bert hubert <bert.hubert@netherlabs.nl>
Date: Wed, 9 Dec 2015 12:56:50 +0000 (+0100)
Subject: toDNSString inexplicably did a toLower() on what it wrote it, potentially causing... 
X-Git-Tag: dnsdist-1.0.0-alpha1~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d04b73457106e0fbbce7846ea808cd4f4ab7c3b;p=thirdparty%2Fpdns.git

toDNSString inexplicably did a toLower() on what it wrote it, potentially causing 0x20 issues. Now, I assume some code needed this. This commit will find that code.
---

diff --git a/pdns/dnsname.cc b/pdns/dnsname.cc
index cfd38efa02..3d4ab7309d 100644
--- a/pdns/dnsname.cc
+++ b/pdns/dnsname.cc
@@ -115,9 +115,7 @@ std::string DNSName::toDNSString() const
   if (empty())
     throw std::out_of_range("Attempt to DNSString an unset dnsname");
 
-  string ret(d_storage.c_str(), d_storage.length());
-  return toLower(ret); // toLower or not toLower, that is the question
-  // return ret;
+  return std::string(d_storage.c_str(), d_storage.length()); // this lowercased.. but why?!
 }
 
 /**