From: Benjamin Berg <bberg@redhat.com>
Date: Mon, 10 Jan 2022 11:35:46 +0000 (+0100)
Subject: xdg-autostart-service: Ignore missing desktop-sepcific condition binary
X-Git-Tag: v251-rc1~542
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d0aef1dd15088e7379681b3bd93c3cb450f3c55;p=thirdparty%2Fsystemd.git

xdg-autostart-service: Ignore missing desktop-sepcific condition binary

If a desktop specific ExecCondition= binary does not exist, this just
means that the desktop environment is not available. As such, it is not
an error condition that should prevent the service from being installed
in the .wants target.

Fix this by simply returning zero.
---

diff --git a/src/xdg-autostart-generator/xdg-autostart-service.c b/src/xdg-autostart-generator/xdg-autostart-service.c
index 32a4958aedc..d450341b9f1 100644
--- a/src/xdg-autostart-generator/xdg-autostart-service.c
+++ b/src/xdg-autostart-generator/xdg-autostart-service.c
@@ -487,7 +487,7 @@ static int xdg_autostart_generate_desktop_condition(
                                        "%s: ExecCondition executable %s not found, unit will not be started automatically: %m",
                                        service->path, test_binary);
                         fprintf(f, "# ExecCondition using %s skipped due to missing binary.\n", test_binary);
-                        return r;
+                        return 0;
                 }
 
                 e_autostart_condition = cescape(condition);