From: Volker Lendecke Date: Fri, 25 Oct 2024 12:53:09 +0000 (+0200) Subject: libnet: Simplify becomeDC X-Git-Tag: tdb-1.4.13~571 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d19d4ab7b31f1ad6acc72b7761be6e61c3116a2;p=thirdparty%2Fsamba.git libnet: Simplify becomeDC Checking for "" does not need a call to strcmp Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- diff --git a/source4/libnet/libnet_become_dc.c b/source4/libnet/libnet_become_dc.c index 968081fb0da..3e22586b22b 100644 --- a/source4/libnet/libnet_become_dc.c +++ b/source4/libnet/libnet_become_dc.c @@ -821,7 +821,7 @@ static void becomeDC_recv_cldap(struct tevent_req *req) DEBUG(0,("CLDAP response: forest=%s dns=%s netbios=%s server_site=%s client_site=%s\n", s->forest.dns_name, s->domain.dns_name, s->domain.netbios_name, s->source_dsa.site_name, s->dest_dsa.site_name)); - if (!s->dest_dsa.site_name || strcmp(s->dest_dsa.site_name, "") == 0) { + if (!s->dest_dsa.site_name || (s->dest_dsa.site_name[0] == '\0')) { DEBUG(0,("Got empty client site - using server site name %s\n", s->source_dsa.site_name)); s->dest_dsa.site_name = s->source_dsa.site_name;