From: Willy Tarreau <w@1wt.eu>
Date: Sat, 16 Oct 2021 12:58:30 +0000 (+0200)
Subject: CLEANUP: listeners: remove unreachable code in clone_listener()
X-Git-Tag: v2.5-dev10~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d19f0d837ce66f307bd3d5aa505bd9e068b4d4e;p=thirdparty%2Fhaproxy.git

CLEANUP: listeners: remove unreachable code in clone_listener()

Coverity reported in issue #1416 that label oom3 is not reachable in
function close_listener() added by commit 59a877dfd ("MINOR: listeners:
add clone_listener() to duplicate listeners at boot time"). The code
leading to it was removed during the development of the function, but
not the label itself.
---

diff --git a/src/listener.c b/src/listener.c
index 5c2eb210a9..c4be8dd0a0 100644
--- a/src/listener.c
+++ b/src/listener.c
@@ -704,8 +704,6 @@ struct listener *clone_listener(struct listener *src)
 	global.maxsock++;
 	return l;
 
- oom3:
-	free(l->name);
  oom2:
 	free(l);
  oom1: