From: Stefan Sørensen Date: Thu, 21 Jan 2016 09:52:46 +0000 (+0100) Subject: re PR target/69187 (ICE: Aborted when native compiling neon code with __builtin_neon_... X-Git-Tag: basepoints/gcc-7~1432 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d31cc758baf6756d0627da19b546625709176c6;p=thirdparty%2Fgcc.git re PR target/69187 (ICE: Aborted when native compiling neon code with __builtin_neon_vmlals_lanev4hi) PR target/69187 PR target/65624 * config/arm/arm-builtins.c (arm_expand_neon_builtin): Increase args array size by one to avoid buffer overflow. * gcc.target/arm/pr69187.c: New test. From-SVN: r232668 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2ea6938f4d6a..a17a403b91ab 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2016-01-21 Stefan Sørensen + Jakub Jelinek + + PR target/69187 + PR target/65624 + * config/arm/arm-builtins.c (arm_expand_neon_builtin): Increase + args array size by one to avoid buffer overflow. + 2016-01-21 Marcin Kościelnicki * config/s390/s390.md (pool_section_start): Use switch_to_section diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c index db6b29d310d5..90fb40fed24c 100644 --- a/gcc/config/arm/arm-builtins.c +++ b/gcc/config/arm/arm-builtins.c @@ -2246,7 +2246,7 @@ arm_expand_neon_builtin (int fcode, tree exp, rtx target) neon_builtin_datum *d = &neon_builtin_data[fcode - ARM_BUILTIN_NEON_PATTERN_START]; enum insn_code icode = d->code; - builtin_arg args[SIMD_MAX_BUILTIN_ARGS]; + builtin_arg args[SIMD_MAX_BUILTIN_ARGS + 1]; int num_args = insn_data[d->code].n_operands; int is_void = 0; int k; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a6bc40c1ece4..3ef65ab9546d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2016-01-21 Jakub Jelinek + PR target/69187 + PR target/65624 + * gcc.target/arm/pr69187.c: New test. + PR c++/69355 * g++.dg/torture/pr69355.C: New test. diff --git a/gcc/testsuite/gcc.target/arm/pr69187.c b/gcc/testsuite/gcc.target/arm/pr69187.c new file mode 100644 index 000000000000..9992a6954b14 --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/pr69187.c @@ -0,0 +1,19 @@ +/* PR target/69187 */ +/* { dg-do compile } */ +/* { dg-require-effective-target arm_neon } */ +/* { dg-options "-O0" } */ +/* { dg-add-options arm_neon } */ + +#include + +int32x4_t +foo (void) +{ + int32x4_t vector_int32x4; + int16x4_t vector3_int16x4; + int16x4_t vector4_int16x4; + static int32_t buffer_int32x4[32]; + + vector_int32x4 = vld1q_s32(buffer_int32x4); + return vqdmlsl_lane_s16(vector_int32x4, vector3_int16x4, vector4_int16x4, 0); +}