From: Serge Hallyn <serge.hallyn@ubuntu.com>
Date: Mon, 7 Apr 2014 17:52:43 +0000 (-0500)
Subject: cgmanager: cgm_get: len = 0 is a query for length only
X-Git-Tag: lxc-1.1.0.alpha1~156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d35844184a450ff36fe72cddc17c193ca3b70b7;p=thirdparty%2Flxc.git

cgmanager: cgm_get: len = 0 is a query for length only

The caller might (like lxc-test-startone does) pass in a valid
(or invalid) buffer and 0 length.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
---

diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c
index 8a5039a76..1dea824b9 100644
--- a/src/lxc/cgmanager.c
+++ b/src/lxc/cgmanager.c
@@ -689,7 +689,7 @@ static int cgm_get(const char *filename, char *value, size_t len, const char *na
 	cgm_dbus_disconnect();
 	free(cgroup);
 	newlen = strlen(result);
-	if (!value) {
+	if (!len || !value) {
 		// user queries the size
 		nih_free(result);
 		return newlen+1;