From: kiko%async.com.br <>
Date: Wed, 14 Apr 2004 03:31:26 +0000 (+0000)
Subject: Additional fix for bug 87770: attachment.cgi should work with no
X-Git-Tag: bugzilla-2.18rc1~90
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d413a7ccc12dcd446f15dbee9a051f52b85f270;p=thirdparty%2Fbugzilla.git

Additional fix for bug 87770: attachment.cgi should work with no
parameters. Use <button> tags to allow for localization of the labels.
r=myk, a=myk.

I padded the Edit button with &nbsp;s to ensure it has the same width as
the View button; it may not be kosher but passes as visually agreeable,
at least.
---

diff --git a/attachment.cgi b/attachment.cgi
index d851e537ee..67e8559c40 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -76,15 +76,6 @@ my $cgi = Bugzilla->cgi;
 # Determine whether to use the action specified by the user or the default.
 my $action = $::FORM{'action'} || 'view';
 
-# Slight awkward extra checks for the case when we came here from the
-# attachment/choose.html.tmpl page
-if ($action eq 'View') {
-    $action = 'view';
-}
-elsif ($action eq 'Edit') {
-    $action = 'edit';
-}
-
 if ($action eq "view")  
 {
   validateID();
diff --git a/template/en/default/attachment/choose.html.tmpl b/template/en/default/attachment/choose.html.tmpl
index b486646534..628dafb969 100644
--- a/template/en/default/attachment/choose.html.tmpl
+++ b/template/en/default/attachment/choose.html.tmpl
@@ -28,8 +28,8 @@
 <form method="get" action="attachment.cgi">
   <p>Access an attachment by entering its ID into the form below:</p>
   <p>Attachment ID: <input name="id" size="6">
-  <input type="submit" name="action" value="Edit">
-  <input type="submit" name="action" value="View">
+  <button name="action" value="edit">&nbsp;Edit&nbsp;</button>
+  <button name="action" value="view">View</button>
   </p>
 </form>