From: Joshua Colp <jcolp@digium.com>
Date: Mon, 21 Apr 2008 14:34:06 +0000 (+0000)
Subject: Only print out the error message if ldap_modify_ext_s actually returns an error,... 
X-Git-Tag: 1.6.2.0-beta1~2427
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d5290a85b51a6409c7f94bc09c7b110a9cf137c;p=thirdparty%2Fasterisk.git

Only print out the error message if ldap_modify_ext_s actually returns an error, and not success.
(closes issue #12438)
Reported by: gservat
Patches:
      res_config_ldap.c-patch-code uploaded by gservat (license 466)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_config_ldap.c b/res/res_config_ldap.c
index 376f9aff88..cb1bd78cb5 100644
--- a/res/res_config_ldap.c
+++ b/res/res_config_ldap.c
@@ -1285,7 +1285,7 @@ static int update_ldap(const char *basedn, const char *table_name, const char *a
 
 		for (i = 0; ldap_entry; i++) { 
 			dn = ldap_get_dn(ldapConn, ldap_entry);
-			if (!(error = ldap_modify_ext_s(ldapConn, dn, ldap_mods, NULL, NULL))) 
+			if ((error = ldap_modify_ext_s(ldapConn, dn, ldap_mods, NULL, NULL)) != LDAP_SUCCESS) 
 				ast_log(LOG_ERROR, "Couldn't modify dn:%s because %s", dn, ldap_err2string(error));
 
 			ldap_entry = ldap_next_entry(ldapConn, ldap_entry);