From: Stefano Brivio <sbrivio@redhat.com>
Date: Wed, 22 Aug 2018 09:22:54 +0000 (+0200)
Subject: Simplify return statement in ipset_mnl_query()
X-Git-Tag: v7.0~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d62c15f947ddb3d86346887a2616a621af515bb;p=thirdparty%2Fipset.git

Simplify return statement in ipset_mnl_query()

As we loop as long as 'ret' is greater than zero, and break only
if we get an error in mnl_cb_run2 (with ret <= 0), we can just
return ret without checking once more if it's greater than zero.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
---

diff --git a/lib/mnl.c b/lib/mnl.c
index a0fa66ec..4e075cf9 100644
--- a/lib/mnl.c
+++ b/lib/mnl.c
@@ -115,7 +115,7 @@ ipset_mnl_query(struct ipset_handle *handle, void *buffer, size_t len)
 		ret = mnl_socket_recvfrom(handle->h, buffer, len);
 		D("message received, ret: %d", ret);
 	}
-	return ret > 0 ? 0 : ret;
+	return ret;
 }
 
 static struct ipset_handle *