From: Stefan Metzmacher Date: Wed, 26 Feb 2020 15:36:30 +0000 (+0100) Subject: lib/tsocket: add a comment regarding TEVENT_FD_READ in tstream_bsd_connect_send() X-Git-Tag: ldb-2.2.0~1587 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d63fa024668d1f02fee0fa6b309497703be6a96;p=thirdparty%2Fsamba.git lib/tsocket: add a comment regarding TEVENT_FD_READ in tstream_bsd_connect_send() This is different compared to the raw usage of [e]poll where [E]POLLOUT is enough to see errors via POLLERR/POLLHUP. Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison --- diff --git a/lib/tsocket/tsocket_bsd.c b/lib/tsocket/tsocket_bsd.c index 1627051f3ec..6ad40bd0ada 100644 --- a/lib/tsocket/tsocket_bsd.c +++ b/lib/tsocket/tsocket_bsd.c @@ -2341,6 +2341,14 @@ static struct tevent_req *tstream_bsd_connect_send(TALLOC_CTX *mem_ctx, goto post; async: + + /* + * Note for historic reasons TEVENT_FD_WRITE is not enough + * to get notified for POLLERR or EPOLLHUP even if they + * come together with POLLOUT. That means we need to + * use TEVENT_FD_READ in addition until we have + * TEVENT_FD_ERROR. + */ state->fde = tevent_add_fd(ev, state, state->fd, TEVENT_FD_READ | TEVENT_FD_WRITE,