From: Razvan Becheriu <razvan@isc.org>
Date: Fri, 26 May 2023 14:10:02 +0000 (+0300)
Subject: [#145] addressed review comments
X-Git-Tag: Kea-2.3.8~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d7caed9b701a290d3bdbe68068926d9277fda61;p=thirdparty%2Fkea.git

[#145] addressed review comments
---

diff --git a/src/lib/dhcpsrv/cfg_subnets6.cc b/src/lib/dhcpsrv/cfg_subnets6.cc
index 9521a573df..97b94eef30 100644
--- a/src/lib/dhcpsrv/cfg_subnets6.cc
+++ b/src/lib/dhcpsrv/cfg_subnets6.cc
@@ -528,7 +528,7 @@ CfgSubnets6::updateStatistics() {
             stats_mgr.setValue(StatsMgr::generateName("subnet", subnet_id,
                                                       StatsMgr::generateName("pool", pool->getID(),
                                                                              "total-nas")),
-                               static_cast<int64_t>(pool->getCapacity()));
+                               pool->getCapacity());
 
             const std::string& name_nas =
                 StatsMgr::generateName("subnet", subnet_id,
@@ -543,7 +543,7 @@ CfgSubnets6::updateStatistics() {
             stats_mgr.setValue(StatsMgr::generateName("subnet", subnet_id,
                                                       StatsMgr::generateName("pd-pool", pool->getID(),
                                                                              "total-pds")),
-                               static_cast<int64_t>(pool->getCapacity()));
+                               pool->getCapacity());
 
             const std::string& name_nas =
                 StatsMgr::generateName("subnet", subnet_id,
diff --git a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
index 5a7b08485e..20df945fa0 100644
--- a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
+++ b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
@@ -630,9 +630,9 @@ SubnetConfigParser::createSubnet(ConstElementPtr params) {
     initSubnet(params, addr, len);
 
     // Add pools to it.
-    for (const auto& it : *pools_) {
+    for (const auto& pool : *pools_) {
         try {
-            subnet_->addPool(it);
+            subnet_->addPool(pool);
         } catch (const BadValue& ex) {
             // addPool() can throw BadValue if the pool is overlapping or
             // is out of bounds for the subnet.