From: Florian Weimer Date: Thu, 25 Mar 2021 10:05:37 +0000 (+0100) Subject: locale: Use compat_symbol_reference in _nl_postload_ctype X-Git-Tag: glibc-2.34~790 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6d8fcee694b9581630a7f27fcbf0009fc44d7baa;p=thirdparty%2Fglibc.git locale: Use compat_symbol_reference in _nl_postload_ctype These symbol usages are not definitions, so compat_symbol_reference is more appropriate than compat_symbol. compat_symbol_reference is also safe to emit multiple times (in case the inline assembly is duplicated; this is possible because it is nested in a function). compat_symbol does not necessarily have this property because it is intended to provide a symbol definition. Reviewed-by: Adhemerval Zanella --- diff --git a/locale/lc-ctype.c b/locale/lc-ctype.c index 1db0605c824..7c97480cbd6 100644 --- a/locale/lc-ctype.c +++ b/locale/lc-ctype.c @@ -93,12 +93,14 @@ _nl_postload_ctype (void) We need those relocations so that a versioned definition with a COPY reloc in an executable will override the libc.so definition. */ -compat_symbol (libc, __ctype_b, __ctype_b, GLIBC_2_0); -compat_symbol (libc, __ctype_tolower, __ctype_tolower, GLIBC_2_0); -compat_symbol (libc, __ctype_toupper, __ctype_toupper, GLIBC_2_0); -compat_symbol (libc, __ctype32_b, __ctype32_b, GLIBC_2_0); -compat_symbol (libc, __ctype32_tolower, __ctype32_tolower, GLIBC_2_2); -compat_symbol (libc, __ctype32_toupper, __ctype32_toupper, GLIBC_2_2); +compat_symbol_reference (libc, __ctype_b, __ctype_b, GLIBC_2_0); +compat_symbol_reference (libc, __ctype_tolower, __ctype_tolower, GLIBC_2_0); +compat_symbol_reference (libc, __ctype_toupper, __ctype_toupper, GLIBC_2_0); +compat_symbol_reference (libc, __ctype32_b, __ctype32_b, GLIBC_2_0); +compat_symbol_reference (libc, __ctype32_tolower, __ctype32_tolower, + GLIBC_2_2); +compat_symbol_reference (libc, __ctype32_toupper, __ctype32_toupper, + GLIBC_2_2); __ctype_b = current (uint16_t, CLASS, 128); __ctype_toupper = current (int32_t, TOUPPER, 128);