From: Diego Fronza <diego@isc.org>
Date: Thu, 13 Feb 2020 23:17:13 +0000 (-0300)
Subject: Fixed rebinding protection bug when using forwarder setups
X-Git-Tag: v9.14.12~7^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6da142ff7f8d48e9c4adbe80f92f63668277bfef;p=thirdparty%2Fbind9.git

Fixed rebinding protection bug when using forwarder setups

BIND wasn't honoring option "deny-answer-aliases" when configured to
forward queries.

Before the fix it was possible for nameservers listed in "forwarders"
option to return CNAME answers pointing to unrelated domains of the
original query, which could be used as a vector for rebinding attacks.

The fix ensures that BIND apply filters even if configured as a forwarder
instance.
---

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index 1ccc0431177..73fc5763dcb 100644
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -6985,9 +6985,15 @@ is_answertarget_allowed(fetchctx_t *fctx, dns_name_t *qname, dns_name_t *rname,
 
 	/*
 	 * If the target name is a subdomain of the search domain, allow it.
+	 *
+	 * Note that if BIND is configured as a forwarding DNS server, the
+	 * search domain will always match the root domain ("."), so we
+	 * must also check whether forwarding is enabled so that filters
+	 * can be applied; see GL #1574.
 	 */
-	if (dns_name_issubdomain(tname, &fctx->domain))
+	if (!fctx->forwarding && dns_name_issubdomain(tname, &fctx->domain)) {
 		return (true);
+	}
 
 	/*
 	 * Otherwise, apply filters.