From: Uwe Kleine-König Date: Thu, 14 Jan 2021 17:57:17 +0000 (+0100) Subject: tty: vcc: Drop unnecessary if block X-Git-Tag: v5.12-rc1~177^2~19 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6da629c85871a0cb65fad3e0c0a440d64002b0a7;p=thirdparty%2Fkernel%2Flinux.git tty: vcc: Drop unnecessary if block If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL value, and if vcc_probe() failed vcc_remove() isn't called. So there is no way dev_get_drvdata() can return NULL in vcc_remove() and the check can just go away. Reviewed-by: Jiri Slaby Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index 9ffd42e333b83..d9b0dc6deae91 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev) { struct vcc_port *port = dev_get_drvdata(&vdev->dev); - if (!port) - return -ENODEV; - del_timer_sync(&port->rx_timer); del_timer_sync(&port->tx_timer);