From: Marcin Siodelski <marcin@isc.org>
Date: Wed, 24 May 2023 06:03:28 +0000 (+0200)
Subject: [#2858] Add the commentary in the test
X-Git-Tag: Kea-2.3.8~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6dcc31315064d563877b232fa6572bdfd5d5eb18;p=thirdparty%2Fkea.git

[#2858] Add the commentary in the test
---

diff --git a/src/bin/dhcp4/tests/dora_unittest.cc b/src/bin/dhcp4/tests/dora_unittest.cc
index 4d7e41c292..bedf20d9bd 100644
--- a/src/bin/dhcp4/tests/dora_unittest.cc
+++ b/src/bin/dhcp4/tests/dora_unittest.cc
@@ -1454,12 +1454,20 @@ DORATest::notAuthoritativeSubnetSelectionFail() {
     client.includeClientId("11:22");
     client.useRelay(true, IOAddress("10.0.0.1"), IOAddress("10.0.0.2"));
 
+    // Current configuration contains a matching subnet from which
+    // the client should get a lease.
     client.doDORA();
 
+    // Let's now reconfigure the server to remove the subnet. The
+    // global authoritative flag is true.
     configure(DORA_CONFIGS[19], *client.getServer());
 
+    // Simulate that the client is in the INIT-REBOOT state. The
+    // client will request the previously assigned address and
+    // remove the server-id.
     client.setState(Dhcp4Client::INIT_REBOOT);
     ASSERT_NO_THROW_LOG(client.doRequest());
+
     // We are not authoritative so the server does not respond
     // at all.
     EXPECT_FALSE(client.getContext().response_);