From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 12 Nov 2025 02:59:18 +0000 (+1300)
Subject: s4:kdc: avoid a leak on error
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6ddf5fd58c06d367e61efc308d270c7e88319a2f;p=thirdparty%2Fsamba.git

s4:kdc: avoid a leak on error

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 50ad2cf12f9..0ce276aee18 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -3464,11 +3464,11 @@ static krb5_error_code samba_kdc_lookup_client(krb5_context context,
 
 			with_dollar = talloc_asprintf(mem_ctx, "%s$",
 						     fallback_account);
+			TALLOC_FREE(fallback_account);
 			if (with_dollar == NULL) {
 				TALLOC_FREE(fallback_realm);
 				return ENOMEM;
 			}
-			TALLOC_FREE(fallback_account);
 
 			ret = smb_krb5_make_principal(context,
 						      &fallback_principal,