From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 6 Feb 2023 14:01:56 +0000 (-0500)
Subject: "secretlen" can't be zero, either
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e00c24773affe74775c98b544d38829b3da2729;p=thirdparty%2Ffreeradius-server.git

"secretlen" can't be zero, either
---

diff --git a/src/protocols/tacacs/base.c b/src/protocols/tacacs/base.c
index 2289b361583..b27dfe6cdae 100644
--- a/src/protocols/tacacs/base.c
+++ b/src/protocols/tacacs/base.c
@@ -143,7 +143,7 @@ int fr_tacacs_body_xor(fr_tacacs_packet_t const *pkt, uint8_t *body, size_t body
 	int pad_offset;
 	size_t pos;
 
-	if (!secret) {
+	if (!secret || !secretlen) {
 		if (pkt->hdr.flags & FR_TAC_PLUS_UNENCRYPTED_FLAG)
 			return 0;
 		else {