From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 16 Aug 2016 13:51:47 +0000 (+0200)
Subject: pipe: SERVFAIL when needed:
X-Git-Tag: dnsdist-1.1.0-beta2~160^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e0daabf5d93bd240c4c3a5ba5afcb843686f3b8;p=thirdparty%2Fpdns.git

pipe: SERVFAIL when needed:

 * SERVFAIL, but don't restart the coprocess if we get a FAIL.
 * SERVFAIL if the coprocess sends something we don't understand.
   * In this case, restart the coprocess.

Closes #4308
---

diff --git a/modules/pipebackend/pipebackend.cc b/modules/pipebackend/pipebackend.cc
index 1154bba77a..b825359a70 100644
--- a/modules/pipebackend/pipebackend.cc
+++ b/modules/pipebackend/pipebackend.cc
@@ -324,10 +324,14 @@ bool PipeBackend::get(DNSResourceRecord &r)
         throw PDNSException("Coprocess backend sent incorrect response '"+line+"'");
     }
   }
+  catch (DBException &dbe) {
+    L<<Logger::Error<<kBackendId<<" "<<dbe.reason<<endl;
+    throw;
+  }
   catch (PDNSException &pe) {
     L<<Logger::Error<<kBackendId<<" "<<pe.reason<<endl;
     cleanup();
-    return false;
+    throw;
   }
   return true;
 }