From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 22 Oct 2020 15:41:26 +0000 (+0200)
Subject: virhashtest: testHashGetItems: Remove test case for sorting by value
X-Git-Tag: v6.10.0-rc1~322
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e296980371710b00fa79fc20fbc5525208659ef;p=thirdparty%2Flibvirt.git

virhashtest: testHashGetItems: Remove test case for sorting by value

Upcoming patch will rewrite virHashGetItems to remove the sorting
function since the prevalent mode is to order by keys.

Remove the test for it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Matt Coleman <matt@datto.com>
---

diff --git a/tests/virhashtest.c b/tests/virhashtest.c
index ad50aae003..8cc3109929 100644
--- a/tests/virhashtest.c
+++ b/tests/virhashtest.c
@@ -368,13 +368,6 @@ testHashGetItemsCompKey(const virHashKeyValuePair *a,
     return strcmp(a->key, b->key);
 }
 
-static int
-testHashGetItemsCompValue(const virHashKeyValuePair *a,
-                          const virHashKeyValuePair *b)
-{
-    return strcmp(a->value, b->value);
-}
-
 static int
 testHashGetItems(const void *data G_GNUC_UNUSED)
 {
@@ -416,18 +409,6 @@ testHashGetItems(const void *data G_GNUC_UNUSED)
     }
     VIR_FREE(array);
 
-    if (!(array = virHashGetItems(hash, testHashGetItemsCompValue)) ||
-        STRNEQ(array[0].key, "c") ||
-        STRNEQ(array[0].value, "1") ||
-        STRNEQ(array[1].key, "b") ||
-        STRNEQ(array[1].value, "2") ||
-        STRNEQ(array[2].key, "a") ||
-        STRNEQ(array[2].value, "3") ||
-        array[3].key || array[3].value) {
-        VIR_TEST_VERBOSE("\nfailed to get items with value sort");
-        goto cleanup;
-    }
-
     ret = 0;
 
  cleanup: