From: Diego Fronza <diego@isc.org>
Date: Fri, 6 Mar 2020 19:53:20 +0000 (-0300)
Subject: Fixed missing list initialization
X-Git-Tag: v9.17.1~68^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e5b4f7ec896ac20a5d41a8e6f20a919dc8f1034;p=thirdparty%2Fbind9.git

Fixed missing list initialization

This commit fixes isc_glob function on windows environments.

The file_list_t * object pointed to by pglob->reserved was missing
ISC_LIST_INIT intialization macro.
---

diff --git a/lib/isc/glob.c b/lib/isc/glob.c
index 9803c59690d..3eb2a7ed46f 100644
--- a/lib/isc/glob.c
+++ b/lib/isc/glob.c
@@ -123,7 +123,7 @@ static int
 glob(const char *pattern, int flags, void *unused, glob_t *pglob) {
 	char path[MAX_PATH];
 	WIN32_FIND_DATAA find_data;
-	;
+	int ec;
 	HANDLE hnd;
 
 	REQUIRE(pattern != NULL);
@@ -159,6 +159,7 @@ glob(const char *pattern, int flags, void *unused, glob_t *pglob) {
 
 	isc_mem_create(&pglob->mctx);
 	pglob->reserved = isc_mem_get(pglob->mctx, sizeof(file_list_t));
+	ISC_LIST_INIT(*(file_list_t *)pglob->reserved);
 
 	size_t entries = 0;
 
@@ -198,7 +199,7 @@ glob(const char *pattern, int flags, void *unused, glob_t *pglob) {
 	return (0);
 
 fail:
-	int ec = errno;
+	ec = errno;
 
 	FindClose(hnd);