From: Dev Jain <dev.jain@arm.com>
Date: Fri, 17 Oct 2025 14:18:43 +0000 (+0530)
Subject: malloc: Do not call madvise if heap's oldsize >= THP size
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e8f32d39a57aa1f31bf15375810aab79a0f5f4b;p=thirdparty%2Fglibc.git

malloc: Do not call madvise if heap's oldsize >= THP size

Linux handles virtual memory in Virtual Memory Areas (VMAs). The
madvise(MADV_HUGEPAGE) call works on a VMA granularity, which sets the
VM_HUGEPAGE flag on the VMA. This flag is invariant of the mprotect()
syscall which is used in growing the secondary heaps. Therefore, we
need to call madvise() only when we are sure that VM_HUGEPAGE was not
previously set, which is only in the case when h->size < mp_.thp_pagesize.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
---

diff --git a/malloc/arena.c b/malloc/arena.c
index 4cd79d7244..2551cb7749 100644
--- a/malloc/arena.c
+++ b/malloc/arena.c
@@ -482,7 +482,10 @@ grow_heap (heap_info *h, long diff)
       h->mprotect_size = new_size;
     }
 
-  madvise_thp (h, new_size);
+  /* mprotect preserves MADV_HUGEPAGE semantics - this means that if the old
+     region was marked with MADV_HUGEPAGE, the new region will retain that.  */
+  if (h->size < mp_.thp_pagesize)
+    madvise_thp (h, new_size);
 
   h->size = new_size;
   LIBC_PROBE (memory_heap_more, 2, h, h->size);