From: Paolo Abeni Date: Mon, 20 May 2019 09:56:52 +0000 (+0200) Subject: m_mirred: don't bail if the control action is missing X-Git-Tag: v5.2.0~34 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6eccf7ecdb010a90e5271942748ef4338ddb61ae;p=thirdparty%2Fiproute2.git m_mirred: don't bail if the control action is missing The mirred act admits an optional control action, defaulting to TC_ACT_PIPE. The parsing code currently emits an error message if the control action is not provided on the command line, even if the command itself completes with no error. This change shuts down the error message, using the appropriate parsing helper. Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions") Signed-off-by: Paolo Abeni Signed-off-by: Stephen Hemminger --- diff --git a/tc/m_mirred.c b/tc/m_mirred.c index c7f7318b8..23ba638a2 100644 --- a/tc/m_mirred.c +++ b/tc/m_mirred.c @@ -202,7 +202,8 @@ parse_direction(struct action_util *a, int *argc_p, char ***argv_p, if (p.eaction == TCA_EGRESS_MIRROR || p.eaction == TCA_INGRESS_MIRROR) - parse_action_control(&argc, &argv, &p.action, false); + parse_action_control_dflt(&argc, &argv, &p.action, false, + TC_ACT_PIPE); if (argc) { if (iok && matches(*argv, "index") == 0) {