From: Volker Lendecke Date: Sat, 31 Dec 2016 12:45:51 +0000 (+0000) Subject: torture-dfs: Use "all_zero" where appropriate X-Git-Tag: samba-4.6.0rc1~29 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6eeb3ec3ab19ddee11829f1d5ac2d13ef1c7b18c;p=thirdparty%2Fsamba.git torture-dfs: Use "all_zero" where appropriate ... Saves a few bytes of footprint Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- diff --git a/source4/torture/dfs/domaindfs.c b/source4/torture/dfs/domaindfs.c index 4981d0f11ee..ee884f1860e 100644 --- a/source4/torture/dfs/domaindfs.c +++ b/source4/torture/dfs/domaindfs.c @@ -307,9 +307,6 @@ static bool test_getsysvolreferral(struct torture_context *tctx, const char* str; struct dfs_GetDFSReferral r, r2, r3; struct dfs_referral_resp resp, resp2, resp3; - uint8_t zeros[16]; - - memset(zeros, 0, sizeof(zeros)); r.in.req.max_referral_level = 3; r.in.req.servername = ""; @@ -394,8 +391,8 @@ static bool test_getsysvolreferral(struct torture_context *tctx, talloc_asprintf(tctx, "Not expected version for referral entry 0 got %d expected 4", resp3.referral_entries[0].version)); - torture_assert_int_equal(tctx, memcmp(resp3.referral_entries[0].referral.v3.service_site_guid.value, zeros, 16), 0, - talloc_asprintf(tctx, + torture_assert(tctx, all_zero(resp3.referral_entries[0].referral.v3.service_site_guid.value, 16), + talloc_asprintf(tctx, "Service_site_guid is not NULL as expected")); #if 0 /* Shouldn't be needed anymore*/