From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 9 Mar 2023 17:07:45 +0000 (+0100)
Subject: qemuhotplugtest: Make the test more useful by validating used commands against QMP... 
X-Git-Tag: v9.3.0-rc1~153
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6eee2de99f70b9caf5dfecacb7440af9657be317;p=thirdparty%2Flibvirt.git

qemuhotplugtest: Make the test more useful by validating used commands against QMP schema

qemuhotplugtest validates only that a given command is used but not the
arguments of the command. With this patch we'll validate the arguments
against the QMP schema thus we can catch possible issues with deprecated
commands.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index 9c8407c5ef..63a6833cfd 100644
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -57,6 +57,7 @@ struct qemuHotplugTestData {
     GHashTable *capsLatestFiles;
     GHashTable *capsCache;
     GHashTable *schemaCache;
+    GHashTable *schema;
 };
 
 static int
@@ -342,7 +343,7 @@ testQemuHotplug(const void *data)
         if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
                                      test->arch, test->capsLatestFiles,
                                      test->capsCache, test->schemaCache,
-                                     NULL) < 0)
+                                     &test->schema) < 0)
             goto cleanup;
     }
 
@@ -356,7 +357,7 @@ testQemuHotplug(const void *data)
 
     /* Now is the best time to feed the spoofed monitor with predefined
      * replies. */
-    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, NULL)))
+    if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, test->schema)))
         goto cleanup;
 
     tmp = test->mon;