From: Noel Power <noel.power@suse.com>
Date: Thu, 8 Aug 2019 14:18:03 +0000 (+0100)
Subject: s3/libsmb: clang: Fix Value set during its initialization is never read
X-Git-Tag: tevent-0.10.1~122
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6ef4736c3f642d5b1625f6edb8b3cfdc6e7e3736;p=thirdparty%2Fsamba.git

s3/libsmb: clang: Fix Value set during its initialization is never read

Fixes:
source3/libsmb/namequery.c:2584:11: warning: Value stored to 'status' during its initialization is never read  <--[clang]
        NTSTATUS status = NT_STATUS_UNSUCCESSFUL;

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 4469db8b009..bb9585dd402 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -2749,7 +2749,7 @@ NTSTATUS internal_resolve_name(const char *name,
 	SAFE_FREE(*return_iplist);
 	*return_count = 0;
 
-	return NT_STATUS_UNSUCCESSFUL;
+	return status;
 
   done: