From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 6 Mar 2025 19:29:21 +0000 (-0500)
Subject: value_box_copy() already sets "secret"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f19bf204a8f41f48dc5596675b5ce78ecf42cb0;p=thirdparty%2Ffreeradius-server.git

value_box_copy() already sets "secret"

so we don't need to do it here
---

diff --git a/src/process/tacacs/base.c b/src/process/tacacs/base.c
index 4dad0bd7e5..5c2820e1ae 100644
--- a/src/process/tacacs/base.c
+++ b/src/process/tacacs/base.c
@@ -796,7 +796,6 @@ RECV(auth_cont)
 #define EXTRACT(_attr) \
 	vp = fr_pair_find_by_da(&request->request_pairs, NULL, attr_tacacs_user_message); \
 	if (!vp) break; \
-	fr_value_box_set_secret(&vp->data, _attr->flags.secret); \
 	if (pair_append_request(&copy, _attr) < 0) break; \
 	if (fr_pair_value_copy(copy, vp) < 0) { \
 		fr_pair_remove(&request->request_pairs, copy); \