From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 22 Feb 2023 02:15:27 +0000 (-0600)
Subject: Indirection apparently shuts up clang scan
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f1a4e93345c3e835810ea01798a0f6ed01a56d0;p=thirdparty%2Ffreeradius-server.git

Indirection apparently shuts up clang scan
---

diff --git a/src/lib/unlang/xlat_builtin.c b/src/lib/unlang/xlat_builtin.c
index 84ddc71e66b..19daa5cc3fb 100644
--- a/src/lib/unlang/xlat_builtin.c
+++ b/src/lib/unlang/xlat_builtin.c
@@ -2363,12 +2363,14 @@ static xlat_action_t xlat_func_concat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 	fr_value_box_t	*result;
 	fr_value_box_t	*list;
 	fr_value_box_t	*separator;
+	FR_DLIST_HEAD(fr_value_box_list) *to_concat;
 	char		*buff;
 	char const	*sep;
 
 	XLAT_ARGS(args, &list, &separator);
 
 	sep = (separator) ? separator->vb_strvalue : "";
+	to_concat = &list->vb_group;
 
 	result = fr_value_box_alloc(ctx, FR_TYPE_STRING, NULL, false);
 	if (!result) {
@@ -2377,7 +2379,7 @@ static xlat_action_t xlat_func_concat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 		return XLAT_ACTION_FAIL;
 	}
 
-	buff = fr_value_box_list_aprint(result, &list->vb_group, sep, NULL);
+	buff = fr_value_box_list_aprint(result, to_concat, sep, NULL);
 	if (!buff) goto error;
 
 	fr_value_box_bstrdup_buffer_shallow(NULL, result, NULL, buff, fr_value_box_list_tainted(args));