From: Evan Hunt <each@isc.org>
Date: Tue, 25 Jun 2024 19:28:23 +0000 (-0700)
Subject: reduce MAX_RESTARTS to 11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f2090586bfc5a063de6b35fa173a1a8fba3702e;p=thirdparty%2Fbind9.git

reduce MAX_RESTARTS to 11

the number of steps that can be followed in a CNAME chain
before terminating the lookup has been reduced from 16 to 11.
(this is a hard-coded value, but will be made configurable later.)

(cherry picked from commit 05d78671bb6a5ba63d78d77339e17cbc73f18188)
(cherry picked from commit dd88a4cdfc8042e2cd2fdae93b803ba8490b88dc)
---

diff --git a/bin/named/query.c b/bin/named/query.c
index f1098056b8d..e5def824bf1 100644
--- a/bin/named/query.c
+++ b/bin/named/query.c
@@ -5999,7 +5999,7 @@ rpz_add_cname(ns_client_t *client, dns_rpz_st_t *st,
 	return (ISC_R_SUCCESS);
 }
 
-#define MAX_RESTARTS 16
+#define MAX_RESTARTS 11
 
 #define QUERY_ERROR(r) \
 do { \
diff --git a/bin/tests/system/chain/tests.sh b/bin/tests/system/chain/tests.sh
index 4aee59f826e..9e25346fd97 100644
--- a/bin/tests/system/chain/tests.sh
+++ b/bin/tests/system/chain/tests.sh
@@ -128,7 +128,7 @@ ret=0
 $RNDCCMD 10.53.0.7 null --- start test$n --- 2>&1 | sed 's/^/ns7 /' | cat_i
 $DIG $DIGOPTS @10.53.0.7 loop.example > dig.out.test$n
 grep "status: NOERROR" dig.out.test$n > /dev/null || ret=1
-grep "ANSWER: 17" dig.out.test$n > /dev/null || ret=1
+grep "ANSWER: 12" dig.out.test$n > /dev/null || ret=1
 if [ $ret != 0 ]; then echo_i "failed"; fi
 status=`expr $status + $ret`
 
diff --git a/lib/dns/client.c b/lib/dns/client.c
index c2dca94bada..9accdf7dd91 100644
--- a/lib/dns/client.c
+++ b/lib/dns/client.c
@@ -63,7 +63,7 @@
 #define UCTX_MAGIC			ISC_MAGIC('U', 'c', 't', 'x')
 #define UCTX_VALID(c)			ISC_MAGIC_VALID(c, UCTX_MAGIC)
 
-#define MAX_RESTARTS 16
+#define MAX_RESTARTS 11
 
 #ifdef TUNE_LARGE
 #define RESOLVER_NTASKS 523