From: Byron Jones <glob@mozilla.com>
Date: Wed, 28 Dec 2011 22:03:56 +0000 (-0500)
Subject: Bug 697699 - (CVE-2011-3657) [SECURITY] XSS when viewing new charts or tabular and... 
X-Git-Tag: bugzilla-4.2rc1~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f323ff54643622bcd31f6b7577ab1a23d16f590;p=thirdparty%2Fbugzilla.git

Bug 697699 - (CVE-2011-3657) [SECURITY] XSS when viewing new charts or tabular and graphical reports in debug mode
r=gerv, a=LpSolit
---

diff --git a/Bugzilla/Chart.pm b/Bugzilla/Chart.pm
index 760db135df..dfbf32a51d 100644
--- a/Bugzilla/Chart.pm
+++ b/Bugzilla/Chart.pm
@@ -438,7 +438,7 @@ sub dump {
     
     require Data::Dumper;
     print "<pre>Bugzilla::Chart object:\n";
-    print Data::Dumper::Dumper($self);
+    print html_quote(Data::Dumper::Dumper($self));
     print "</pre>";
 }
 
diff --git a/report.cgi b/report.cgi
index a71776bfe6..dccc470a7b 100755
--- a/report.cgi
+++ b/report.cgi
@@ -288,9 +288,9 @@ print $cgi->header(-type => $format->{'ctype'},
 if ($cgi->param('debug')) {
     require Data::Dumper;
     print "<pre>data hash:\n";
-    print Data::Dumper::Dumper(%data) . "\n\n";
+    print html_quote(Data::Dumper::Dumper(%data)) . "\n\n";
     print "data array:\n";
-    print Data::Dumper::Dumper(@image_data) . "\n\n</pre>";
+    print html_quote(Data::Dumper::Dumper(@image_data)) . "\n\n</pre>";
 }
 
 # All formats point to the same section of the documentation.