From: Jorge Pereira <jpereira@users.noreply.github.com>
Date: Wed, 8 Feb 2023 15:50:53 +0000 (-0300)
Subject: Don't leak memory on invalid packet code (#4887)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f5c82143d1404bf5f3cc6fa07445cff3b210eeb;p=thirdparty%2Ffreeradius-server.git

Don't leak memory on invalid packet code (#4887)
---

diff --git a/src/protocols/tacacs/decode.c b/src/protocols/tacacs/decode.c
index dcf18839bfc..7265b3c5e4d 100644
--- a/src/protocols/tacacs/decode.c
+++ b/src/protocols/tacacs/decode.c
@@ -472,7 +472,7 @@ ssize_t fr_tacacs_decode(TALLOC_CTX *ctx, fr_pair_list_t *out, uint8_t const *bu
 
 		if (code) {
 			*code = fr_tacacs_packet_to_code((fr_tacacs_packet_t const *) decrypted);
-			if (*code < 0) return -1;
+			if (*code < 0) goto fail;
 		}
 	}