From: Volker Lendecke <vl@samba.org>
Date: Wed, 24 Dec 2025 09:58:52 +0000 (+0100)
Subject: lib: Remove unnecessary assignments
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f6ee0436421a27362b151f7121004ead6570aaa;p=thirdparty%2Fsamba.git

lib: Remove unnecessary assignments

data_blob_free() already NULLs out its argument

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index 644f40275ee..4e2999ec60a 100644
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -960,7 +960,6 @@ bool asn1_read_OctetString(struct asn1_data *data, TALLOC_CTX *mem_ctx, DATA_BLO
   err:
 
 	data_blob_free(blob);
-	*blob = data_blob_null;
 	return false;
 }
 
@@ -1047,7 +1046,6 @@ bool asn1_read_BitString(struct asn1_data *data, TALLOC_CTX *mem_ctx, DATA_BLOB
 
 	if (data->has_error) {
 		data_blob_free(blob);
-		*blob = data_blob_null;
 		*padding = 0;
 		return false;
 	}
diff --git a/source3/utils/ntlm_auth.c b/source3/utils/ntlm_auth.c
index ced45fe61c9..d32a9850980 100644
--- a/source3/utils/ntlm_auth.c
+++ b/source3/utils/ntlm_auth.c
@@ -2007,11 +2007,8 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
 		}
 		/* clear out the state */
 		data_blob_free(&challenge);
-		challenge = data_blob_null;
 		data_blob_free(&nt_response);
-		nt_response = data_blob_null;
 		data_blob_free(&lm_response);
-		lm_response = data_blob_null;
 		SAFE_FREE(full_username);
 		SAFE_FREE(username);
 		SAFE_FREE(domain);