From: Matthew Nicholson <mnicholson@digium.com>
Date: Fri, 17 Sep 2010 13:34:34 +0000 (+0000)
Subject: Use ast_strdup() instead of ast_strdupa() while processing in ast_hint_state_changed().
X-Git-Tag: 1.4.37-rc1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f73ea7750869cf9eb2637ecd63b577ab65bb803;p=thirdparty%2Fasterisk.git

Use ast_strdup() instead of ast_strdupa() while processing in ast_hint_state_changed().

(related to issue #17928)
Reported by: mdu113


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@287307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/pbx.c b/main/pbx.c
index 67d4ac71a9..c232b9bb20 100644
--- a/main/pbx.c
+++ b/main/pbx.c
@@ -2017,14 +2017,19 @@ void ast_hint_state_changed(const char *device)
 
 	AST_LIST_TRAVERSE(&hints, hint, list) {
 		struct ast_state_cb *cblist;
-		char *parse = ast_strdupa(ast_get_extension_app(hint->exten));
-		char *cur;
+		/* can't use ast_strdupa() here because we may run out of stack
+		 * space while looping over a large number of large strings */
+		char *dup = ast_strdup(ast_get_extension_app(hint->exten));
+		char *cur, *parse = dup;
 		int state;
 
 		while ( (cur = strsep(&parse, "&")) ) {
 			if (!strcasecmp(cur, device))
 				break;
 		}
+
+		ast_free(dup);
+
 		if (!cur)
 			continue;