From: Richard E. Silverman <res@qoxp.net>
Date: Fri, 4 Apr 2025 02:09:11 +0000 (-0400)
Subject: Fix typo in AS-REQ client code
X-Git-Tag: krb5-1.22-beta1~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f8292ca20bddf1de23b9f525e54a3a674c46b8b;p=thirdparty%2Fkrb5.git

Fix typo in AS-REQ client code

Add a missing "else" to init_creds_step_request().  The mistake was
harmless because optimistic preauth can only be present for the first
step, and the other conditions can only be true after the state
machine has processed an error reply.

[ghudson@mit.edu: rewrote commit message]
---

diff --git a/src/lib/krb5/krb/get_in_tkt.c b/src/lib/krb5/krb/get_in_tkt.c
index 4833255d99..4b2be41e75 100644
--- a/src/lib/krb5/krb/get_in_tkt.c
+++ b/src/lib/krb5/krb/get_in_tkt.c
@@ -1307,7 +1307,7 @@ init_creds_step_request(krb5_context context,
             krb5_clear_error_message(context);
             code = 0;
         }
-    } if (ctx->more_padata != NULL) {
+    } else if (ctx->more_padata != NULL) {
         /* Continuing after KDC_ERR_MORE_PREAUTH_DATA_REQUIRED. */
         TRACE_INIT_CREDS_PREAUTH_MORE(context, ctx->selected_preauth_type);
         code = k5_preauth(context, ctx, ctx->more_padata, TRUE,