From: Jan Safranek <jsafrane@redhat.com>
Date: Thu, 6 Aug 2009 12:03:26 +0000 (+0200)
Subject: Remove unnecessary includes from libcgroup.h
X-Git-Tag: v0.35~40
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f93cd767947d29c51a8d9fefeb7e582b0a324a2;p=thirdparty%2Flibcgroup.git

Remove unnecessary includes from libcgroup.h

libcgroup.h includes some header files, which are not then used. These should
be removed, resp. moved to the source files where they are actually needed.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
---

diff --git a/include/libcgroup.h b/include/libcgroup.h
index b8a3a773..f4245626 100644
--- a/include/libcgroup.h
+++ b/include/libcgroup.h
@@ -21,13 +21,9 @@
 __BEGIN_DECLS
 
 #include <grp.h>
-#include <linux/types.h>
 #include <stdbool.h>
 #include <stdio.h>
-#include <sys/stat.h>
 #include <sys/types.h>
-#include <unistd.h>
-#include <limits.h>
 #include <linux/cn_proc.h>
 
 #ifndef _GNU_SOURCE
diff --git a/src/daemon/cgrulesengd.h b/src/daemon/cgrulesengd.h
index ddb1af0c..97c62f11 100644
--- a/src/daemon/cgrulesengd.h
+++ b/src/daemon/cgrulesengd.h
@@ -22,6 +22,7 @@ __BEGIN_DECLS
 #include "config.h"
 #include "libcgroup.h"
 #include <linux/connector.h>
+#include <linux/cn_proc.h>
 
 #ifndef _GNU_SOURCE
 #define _GNU_SOURCE
diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index 9920be39..78665e74 100644
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -7,6 +7,7 @@
 #include <pwd.h>
 #include <sys/types.h>
 #include <errno.h>
+#include <unistd.h>
 
 #include "tools-common.h"
 
diff --git a/src/tools/cgdelete.c b/src/tools/cgdelete.c
index 0a2c238d..51d89221 100644
--- a/src/tools/cgdelete.c
+++ b/src/tools/cgdelete.c
@@ -20,6 +20,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <errno.h>
+#include <unistd.h>
 
 #include "tools-common.h"
 
diff --git a/tests/libcgrouptest.h b/tests/libcgrouptest.h
index 4ee9464e..923828ac 100644
--- a/tests/libcgrouptest.h
+++ b/tests/libcgrouptest.h
@@ -26,9 +26,10 @@
 #include <string.h>
 #include <sys/syscall.h>
 #include <sys/types.h>
-
+#include <sys/stat.h>
 #include <libcgroup.h>
 #include "../config.h"
+#include <unistd.h>
 
 #define SIZE 100	/* Max size of a message to be printed */
 #define NUM_MSGS 20	/* Number of such messsages */