From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 29 Jul 2016 15:05:28 +0000 (-0400)
Subject: Enable JSON testing for pymysql
X-Git-Tag: rel_1_1_0~66^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6f9e8f482c133eca993124d63d61463fd2770f66;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Enable JSON testing for pymysql

PyMySQL upstream has released 0.7.6 which should resolve
JSON encoding issues.

Change-Id: Icf543d48dace1419a0aac78bdb15ec666f0edafe
Fixes: #3754
---

diff --git a/test/requirements.py b/test/requirements.py
index 5f366ba478..9286a415d1 100644
--- a/test/requirements.py
+++ b/test/requirements.py
@@ -574,10 +574,7 @@ class DefaultRequirements(SuiteRequirements):
     def json_type(self):
         return only_on([
             lambda config: against(config, "mysql >= 5.7") and
-            not config.db.dialect._is_mariadb and
-            # workaround for:
-            # https://github.com/PyMySQL/PyMySQL/issues/488
-            not (config.db.dialect.driver == 'pymysql'),
+            not config.db.dialect._is_mariadb,
             "postgresql >= 9.3"
         ])