From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 11 Jul 2023 18:35:36 +0000 (-0400)
Subject: check returns.  CID #1503939  Fixes #5103
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6fc70fd59cddfc394f4a88e9fc27cd6c4e7e0bf0;p=thirdparty%2Ffreeradius-server.git

check returns.  CID #1503939  Fixes #5103
---

diff --git a/src/lib/util/edit_tests.c b/src/lib/util/edit_tests.c
index 836071d3053..55e1411edfb 100644
--- a/src/lib/util/edit_tests.c
+++ b/src/lib/util/edit_tests.c
@@ -82,15 +82,18 @@ static void test_init(void)
 static void add_pairs(fr_pair_list_t *local_pairs)
 {
 	int count;
+	fr_pair_t *vp;
 
 	fr_pair_list_init(local_pairs);
 
-	/* coverity[dereference] */
-	fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32));
-	/* coverity[dereference] */
-	fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_octets));
-	/* coverity[dereference] */
-	fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv));
+	TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32)) != NULL);
+	fr_pair_append(local_pairs, vp);
+
+	TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets)) != NULL);
+	fr_pair_append(local_pairs, vp);
+
+	TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv)) != NULL);
+	fr_pair_append(local_pairs, vp);
 
 	count = fr_pair_list_num_elements(local_pairs);
 	TEST_CASE("Expected (count == 3)");