From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Sat, 12 Jul 2008 06:07:28 +0000 (+0200)
Subject: More cache manager initialization calls reshuffling.
X-Git-Tag: SQUID_3_1_0_1~49^2~143^2~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6fdc2d18a4f236854361a7d66a0452e6ce0454af;p=thirdparty%2Fsquid.git

More cache manager initialization calls reshuffling.
---

diff --git a/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.cc b/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.cc
index 4f1848a278..0097fd7921 100644
--- a/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.cc
+++ b/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.cc
@@ -69,6 +69,8 @@ DiskDaemonDiskIOModule::init()
     debugs(47, 1, "diskd started");
 #endif
     initialised = true;
+
+    registerWithCacheManager();
 }
 
 void
diff --git a/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h b/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h
index a47395ed5a..0b7fca389b 100644
--- a/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h
+++ b/src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h
@@ -43,7 +43,6 @@ public:
     static DiskDaemonDiskIOModule &GetInstance();
     DiskDaemonDiskIOModule();
     virtual void init();
-    virtual void registerWithCacheManager(void);
     virtual void shutdown();
     virtual char const *type () const;
     virtual DiskIOStrategy* createStrategy();
@@ -52,6 +51,7 @@ private:
     static void Stats(StoreEntry * sentry);
     static DiskDaemonDiskIOModule Instance;
     bool initialised;
+    void registerWithCacheManager(void);
 };
 
 #endif /* SQUID_DISKDAEMONDISKIOMODULE_H */
diff --git a/src/DiskIO/DiskIOModule.cc b/src/DiskIO/DiskIOModule.cc
index 71e1c4e3e0..a9d77cd1b6 100644
--- a/src/DiskIO/DiskIOModule.cc
+++ b/src/DiskIO/DiskIOModule.cc
@@ -48,13 +48,6 @@ DiskIOModule::DiskIOModule()
      */
 }
 
-void
-DiskIOModule::RegisterAllModulesWithCacheManager(void)
-{
-    for (iterator i = GetModules().begin(); i != GetModules().end(); ++i)
-        (*i)->registerWithCacheManager();
-}
-
 void
 DiskIOModule::SetupAllModules()
 {
@@ -130,7 +123,3 @@ DiskIOModule::FindDefault()
     return result;
 }
 
-/* disk modules dont export anything by default */
-void
-DiskIOModule::registerWithCacheManager(void)
-{}
diff --git a/src/DiskIO/DiskIOModule.h b/src/DiskIO/DiskIOModule.h
index a0b33322f3..a766e1c907 100644
--- a/src/DiskIO/DiskIOModule.h
+++ b/src/DiskIO/DiskIOModule.h
@@ -63,7 +63,7 @@ public:
     virtual ~DiskIOModule(){}
 
     virtual void init() = 0;
-    virtual void registerWithCacheManager(void);
+    //virtual void registerWithCacheManager(void);
     virtual void shutdown() = 0;
     virtual DiskIOStrategy *createStrategy() = 0;
 
diff --git a/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.cc b/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.cc
index 2dff881a02..5a07b426d5 100644
--- a/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.cc
+++ b/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.cc
@@ -53,12 +53,6 @@ DiskThreadsDiskIOModule::init()
     DiskThreadsIOStrategy::Instance.init();
 }
 
-void
-DiskThreadsDiskIOModule::registerWithCacheManager(void)
-{
-    DiskThreadsIOStrategy::Instance.registerWithCacheManager();
-}
-
 void
 DiskThreadsDiskIOModule::shutdown()
 {
diff --git a/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h b/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h
index 0435841d73..6f186191b3 100644
--- a/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h
+++ b/src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h
@@ -43,7 +43,7 @@ public:
     static DiskThreadsDiskIOModule &GetInstance();
     DiskThreadsDiskIOModule();
     virtual void init();
-    virtual void registerWithCacheManager(void);
+    //virtual void registerWithCacheManager(void);
     virtual void shutdown();
     virtual char const *type () const;
     virtual DiskIOStrategy* createStrategy();
diff --git a/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.cc b/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.cc
index ab1f101b8a..bbc5580cd3 100644
--- a/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.cc
+++ b/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.cc
@@ -58,6 +58,8 @@ DiskThreadsIOStrategy::init(void)
      * hasn't been parsed yet and we don't know how many cache_dirs
      * there are, which means we don't know how many threads to start.
      */
+
+     registerWithCacheManager();
 }
 
 void
diff --git a/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h b/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h
index 1ff47da0c9..73bb580275 100644
--- a/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h
+++ b/src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h
@@ -58,7 +58,6 @@ public:
     virtual int callback();
     virtual void sync();
     virtual void init();
-    virtual void registerWithCacheManager(void);
     void done();
     /* Todo: add access limitations */
     bool initialised;
@@ -67,6 +66,7 @@ public:
 
 private:
     static void aioStats(StoreEntry * sentry);
+    void registerWithCacheManager(void);
 };
 
 #endif
diff --git a/src/authenticate.cc b/src/authenticate.cc
index 394ba765a9..ea584fa063 100644
--- a/src/authenticate.cc
+++ b/src/authenticate.cc
@@ -87,6 +87,8 @@ authenticateInit(authConfig * config)
         AuthUser::cacheInit();
     else
         AuthUser::CachedACLsReset();
+
+    authenticateRegisterWithCacheManager(&Config.authConfiguration);
 }
 
 void
diff --git a/src/delay_pools.cc b/src/delay_pools.cc
index 254ac6e2f6..c593fce3b4 100644
--- a/src/delay_pools.cc
+++ b/src/delay_pools.cc
@@ -553,6 +553,7 @@ void
 DelayPools::Init()
 {
     LastUpdate = getCurrentTime();
+    RegisterWithCacheManager();
 }
 
 void
diff --git a/src/main.cc b/src/main.cc
index bb0fd913a2..7d0ea9cd38 100644
--- a/src/main.cc
+++ b/src/main.cc
@@ -728,7 +728,7 @@ mainReconfigure(void)
     serverConnectionsOpen();
 
     neighbors_init();
-    neighborsRegisterWithCacheManager();
+    // neighborsRegisterWithCacheManager(); //moved to neighbors_init()
 
     storeDirOpenSwapLogs();
 
@@ -966,7 +966,8 @@ mainInitialize(void)
         /* register the modules in the cache manager menus */
         // accessLogRegisterWithCacheManager(); //moved to accessLogInit()
         // asnRegisterWithCacheManager(); //moved to asnInit()
-        authenticateRegisterWithCacheManager(&Config.authConfiguration);
+        // authenticateRegisterWithCacheManager(&Config.authConfiguration);
+	//   moved authenticateInit()
 #if USE_CARP
         // carpRegisterWithCacheManager(); //moved to carpInit()
 #endif
@@ -991,10 +992,11 @@ mainInitialize(void)
         //clientdbRegisterWithCacheManager(); //moved to clientdbInit()
 #if DELAY_POOLS
 
-        DelayPools::RegisterWithCacheManager();
+        //DelayPools::RegisterWithCacheManager(); //moved to DelayPools::Init()
 #endif
 
-        DiskIOModule::RegisterAllModulesWithCacheManager();
+        //DiskIOModule::RegisterAllModulesWithCacheManager();
+	//  moved to each module's init() function
 #if USE_DNSSERVERS
 
         dnsRegisterWithCacheManager();
diff --git a/src/neighbors.cc b/src/neighbors.cc
index 0eaf23707f..3ffcb4751f 100644
--- a/src/neighbors.cc
+++ b/src/neighbors.cc
@@ -499,6 +499,8 @@ neighbors_init(void)
     peer *next = NULL;
     int fd = theInIcpConnection;
 
+    neighborsRegisterWithCacheManager();
+
     /* setup addrinfo for use */
     nul.InitAddrInfo(AI);